(cleanup) remove code related to v1,v2 protocols #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why I did not remove it as part of scylladb#493 Signed-off-by: Yaniv Kaul <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated code related to v1 and v2 protocols, cleaning up the codebase after the previous removal of protocol v1/v2 support. The changes eliminate outdated connection pooling configurations and related test code that was specific to older protocol versions.
- Removes deprecated connection pooling methods and constants from the Cluster class
- Cleans up test files to remove protocol version-specific connection configurations
- Updates documentation to remove references to deprecated connection pooling methods
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cassandra/cluster.py | Removes connection pooling constants, configuration dictionaries, and deprecated getter/setter methods for core/max connections per host |
| cassandra/concurrent.py | Simplifies documentation by removing protocol version-specific concurrency recommendations |
| tests/unit/test_host_connection_pool.py | Removes mock setup for deprecated connection pooling methods |
| tests/integration/standard/test_query_paging.py | Removes protocol version check and connection configuration |
| tests/integration/standard/test_query.py | Removes protocol version checks and connection configurations from two test classes |
| tests/integration/standard/test_concurrent.py | Removes protocol version check and connection configuration |
| tests/integration/standard/test_cluster.py | Removes protocol version check and connection configuration |
| docs/api/cassandra/cluster.rst | Removes documentation for deprecated connection pooling methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Lorak-mmk
approved these changes
Aug 14, 2025
dkropachev
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why I did not remove it as part of #493
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.